[Unionfs] Unionfs Patch Problem

[Ngo, Andrew]

Hi, Erez,

Thanks for your advice, I turn off the CONFIG_UNION_FS_XATTR and the
compile error "implicit declaration of function 
'vfs_listxattr'" goes away.  Thank you so much.  The compilation was on
kernel directory patched with unionfs-2.3.3_for_2.6.18.8.centos5.diff.gz
(file size 241K) sent by Fernando Gomes.

I also want to feed back to you on the patch file you just created
unionfs-2.3.3_for_2.6.18-RHEL5.diff.gz (file size 88K).  The patch
command on this diff file generated some errors (See patch.out).  I
don't know if the patch failures are caused by the minor revision
difference on the RHEL5 (My RHEL5 has kernel version of 2.6.18-8, the
kernel tarball that Konard provided to you has version of 2.6.18-53 -
RHEL5.1 kernel), or the patch failures are caused by other things.

Anyway, for the time being, I will patch with
unionfs-2.3.3_for_2.6.18.8.centos5.diff.gz, compile with
CONFIG_UNION_FS_XATTR turned off, and will  be moving to the testing
phase of unionfs soon.  If you happen to create another version of
unionfs-2.3.3_for_2.6.18-RHEL5.diff.gz, I will be glad to test it for
you.

Once again, thanks to everyone that helped with this patching problem.

Andy Ngo

-----Original Message-----
From: unionfs-bounces at fsl.cs.sunysb.edu
[mailto:unionfs-bounces at fsl.cs.sunysb.edu] On Behalf Of Erez Zadok
Sent: Wednesday, May 07, 2008 1:12 PM
To: Ngo, Andrew
Cc: Fernando A. P. Gomes; Johnson, Je; unionfs at fsl.cs.sunysb.edu
Subject: Re: [Unionfs] Unionfs Patch Problem

In message
<AC33E917323B7F429C94A5B919B4CD18067C9CD2 at emss04m05.us.lmco.com>, "Ngo,
Andrew" writes:

> Hi,
> 
> The patching of unionfs-2.3.3_for_2.6.18.8.centos5.diff.gz needs 
> various files (fs/stack.c, include/linux/fs_stack.h), and directory 
> (fs/unionfs).  So I did not proceed with this route.  The 
> unionfs-2.3.3_for_2.6.18.8.centos5.diff.gz, however, generates good 
> patch files (drivers/md/dm-mpath.h, fs/Makefile, and 
> include/linux/namei.h).  I copied these files generated/patched from 
> unionfs-2.3.3_for_2.6.18.8.centos5.diff.gz
> 
> Now, I am patching the RHEL5 kernel 2.6.18.8.el5 with the original 
> unionfs-2.3.3_for_2.6.18.8.diff.gz, and then overlay the above three 
> files saved from patching with the 
> unionfs-2.3.3_for_2.6.18.8.centos5.diff.gz.
> 
> The compile operation went further, but eventually it failed (See 
> attached make.out1 file).
> 
>   CC [M]  fs/unionfs/rdstate.o
>   CC [M]  fs/unionfs/copyup.o
> fs/unionfs/copyup.c: In function 'copyup_xattrs':
> fs/unionfs/copyup.c:38: error: implicit declaration of function 
> 'vfs_listxattr'
> make[2]: *** [fs/unionfs/copyup.o] Error 1
> make[1]: *** [fs/unionfs] Error 2
> make: *** [fs] Error 2
> 
> Does anyone know how to fix this compile problem???  Thanks in
advance.
> 
> Andy Ngo

Andy, there's no xattr support in unionfs for 2.6.18 (the VFS was
lacking some vital support, I don't recommend it).  So plz turn off
CONFIG_UNION_FS_XATTR.

Anyway, thanks to Konrad's rhel5 tarball, I produced now a unionfs-2.3.3
patch which applies and compiles  cleanly on rhel5.  See

http://download.filesystems.org/unionfs/unionfs-2.x/unionfs-2.3.3_for_2.
6.18-RHEL5.diff.gz

Cheers,
Erez.
_______________________________________________
unionfs mailing list: http://unionfs.filesystems.org/
unionfs at mail.fsl.cs.sunysb.edu
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.out.1
Type: application/octet-stream
Size: 2869 bytes
Desc: patch.out.1
Url : http://www.fsl.cs.sunysb.edu/pipermail/unionfs/attachments/20080507/d2a8b1e7/patch.out.obj